🐛 fix(*): 修复代码审查中发现的问题

- **Bug 修复**
  - `message.py`: 批量发送时使用 `(index, msg)` 元组替代 `messages.index(msg)`,避免重复 dict 查找错误
  - `message.py`: 多张图片逐张发送,不再静默丢弃后续图片
  - `plugin.py`: API Key 日志只打印"已配置/自动生成",不再泄露密钥

- **潜在问题修复**
  - `message.py`: lambda 闭包添加默认参数绑定,防止循环变量捕获问题
  - `upload.py`: 文件超限后消费剩余 multipart 数据,避免 reader 状态异常
  - `config.py`: PORT 环境变量非法值容错,默认回退 8081
  - `plugin.py`: cleanup task 保存引用,on_close 时正确取消,避免热重载泄漏

- **代码风格**
  - `message.py`: 无插值 f-string 改为普通字符串
  - `upload.py`: read_chunk 硬编码提取为 CHUNK_SIZE 常量
This commit is contained in:
2026-05-02 15:28:54 +08:00
parent 67e328942c
commit b86a2d4c4e
4 changed files with 214 additions and 160 deletions

View File

@@ -2,6 +2,7 @@
import asyncio
import logging
import os
from aiohttp import web
from ncatbot.plugin import NcatBotPlugin
@@ -24,14 +25,22 @@ class WebHookPlugin(NcatBotPlugin):
def __init__(self, *args, **kwargs):
super().__init__(*args, **kwargs)
self._webhook_runner: web.AppRunner | None = None
self._cleanup_task: asyncio.Task | None = None
async def on_load(self):
self.logger.info("Webhook 插件已加载")
self.logger.info("WEBHOOK_API_KEY: %s", WEBHOOK_API_KEY)
self.logger.info("WEBHOOK_API_KEY: %s", "已配置" if os.environ.get("WEBHOOK_API_KEY") else "自动生成")
asyncio.create_task(self._start_webhook())
asyncio.create_task(self._cleanup_loop())
self._cleanup_task = asyncio.create_task(self._cleanup_loop())
async def on_close(self):
if self._cleanup_task is not None:
self._cleanup_task.cancel()
try:
await self._cleanup_task
except asyncio.CancelledError:
pass
self._cleanup_task = None
await self._stop_webhook()
self.logger.info("Webhook 插件已卸载")